Fix #1185 - Add additionalProperties when type object has default value and no props #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
added
area:client
Member
Author
|
@edeandrea, mind taking a look on your side? We set That won't fix the model, though. You may notice inconsistencies in your API. The ideal solution is to resolve the issue on the server side. |
ricardozanini
commented
Jun 13, 2025
| [.description] | ||
| -- | ||
| Path to the Moqu (relative to the project). | ||
| Path to the Moqu OpenAPI files, relative to the `src/main/resources` directory. |
Member
Author
There was a problem hiding this comment.
@mcruzdev when sending PRs to server/moqu make sure to run the whole build, from the top, locally.
…default value and no props Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
force-pushed
the
issue-1185
branch
from
2ec246b to
824ad70
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...a/io/quarkiverse/openapi/generator/deployment/wrapper/OpenApiClientGeneratorWrapperTest.java
Dismissed
Show dismissed
Hide dismissed
...a/io/quarkiverse/openapi/generator/deployment/wrapper/OpenApiClientGeneratorWrapperTest.java
Dismissed
Show dismissed
Hide dismissed
hbelmiro
approved these changes
Jun 15, 2025
gmunozfe
approved these changes
Jun 16, 2025
Contributor
gmunozfe
left a comment
gmunozfe
left a comment
There was a problem hiding this comment.
Just a minor comment, good work @ricardozanini !
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gonzalo Muñoz <[email protected]>
wmedvede
approved these changes
Jun 16, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…ue and no props (#1193) * Fix #1185 - Add additionalProperties when type object has default value and no props Signed-off-by: Ricardo Zanini <[email protected]> * Fix Windows path Signed-off-by: Ricardo Zanini <[email protected]> * Adding Gonzalo's comment Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
7 tasks
ricardozanini
added a commit
that referenced
this pull request
Jun 16, 2025
…ue and no props (#1193) (#1199) * Fix #1185 - Add additionalProperties when type object has default value and no props * Fix Windows path * Adding Gonzalo's comment --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1185
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.